CMakeLists: Adjust for CMake 4.0's removal of deprecated syntax. - #1140
Open
renodr wants to merge 1 commit into
Open
CMakeLists: Adjust for CMake 4.0's removal of deprecated syntax.#1140renodr wants to merge 1 commit into
renodr wants to merge 1 commit into
Conversation
CMake 4.0 is more strict than previous versions, and has enforced removals of deprecated syntax. Compatibility with versions of CMake prior to 3.5 is no longer permitted either, so we'll change it to say 4.0 to fix that problem. After that, the custom commands for generating the manual page need to be adjusted as CMake now needs to know when to run commands, so we will generate the manual page after the package is built by passing POST_BUILD to the custom commands. Tested with CMake 4.0 and 3.31.6.
|
Why don't you simply raise the minimum to something >=3.5, or >=3.10 (to get rid of yet another deprecation warning)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 4.0 is more strict than previous versions, and has enforced removals of deprecated syntax. Compatibility with versions of CMake prior to 3.5 is no longer permitted either, so we'll change it to say 4.0 to fix that problem. After that, the custom commands for generating the manual page need to be adjusted as CMake now needs to know when to run commands, so we will generate the manual page after the package is built by passing POST_BUILD to the custom commands.
Tested with CMake 4.0 and 3.31.6.
Fixes #1139